From 2ccccc5ce191c91d84184f7372fa0914daee4894 Mon Sep 17 00:00:00 2001
From: Tellsanguis <tellsanguis@DESKTOP-L4EERCF.localdomain>
Date: Wed, 26 Nov 2025 17:51:03 +0100
Subject: [PATCH] fix(terraform): Configure storage for LINSTOR cluster
 topology

Storage configuration changes:
- Add full_clone=true for better LINSTOR compatibility
- Add replicate=1 to disk config for k3s servers on LINSTOR
- Configure etcd-witness to use local-lvm storage on thinkpad
- Add etcd_witness_storage_pool variable with local-lvm default

Fixes:
- etcd-witness now uses local storage since thinkpad is LINSTOR controller only
- k3s-server-1 and k3s-server-2 use LINSTOR replicated storage on acemagician/elitedesk
- Explicit replication flag helps LINSTOR create resources correctly
---
 .forgejo/workflows/deploy.yml | 27 ++++++++++++++-------------
 terraform/pve1/main.tf        |  2 ++
 terraform/pve2/main.tf        |  2 ++
 terraform/pve3/main.tf        |  3 ++-
 terraform/pve3/variables.tf   |  6 ++++++
 5 files changed, 26 insertions(+), 14 deletions(-)

diff --git a/.forgejo/workflows/deploy.yml b/.forgejo/workflows/deploy.yml
index 302a320..0d330d2 100644
--- a/.forgejo/workflows/deploy.yml
+++ b/.forgejo/workflows/deploy.yml
@@ -153,19 +153,20 @@ jobs:
         run: |
           cd terraform/pve3
           cat > terraform.tfvars <<EOF
-          proxmox_token_id      = "${{ secrets.PROXMOX_TOKEN_ID }}"
-          proxmox_token_secret  = "${{ secrets.PROXMOX_TOKEN_SECRET }}"
-          ssh_public_key        = "${{ secrets.SSH_PUBLIC_KEY }}"
-          forgejo_token         = "${{ secrets.GIT_TOKEN }}"
-          forgejo_repo_url      = "${{ secrets.GIT_REPO_URL }}"
-          k3s_version           = "v1.28.5+k3s1"
-          ubuntu_template       = "ubuntu-2404-cloudinit"
-          storage_pool          = "linstor_storage"
-          snippets_storage      = "local"
-          k3s_network_bridge    = "k3s"
-          k3s_gateway           = "10.100.20.1"
-          k3s_dns               = ["10.100.20.1", "1.1.1.1"]
-          etcd_witness_config   = { ip = "10.100.20.30/24", cores = 2, memory = 2048, disk_size = "20G" }
+          proxmox_token_id           = "${{ secrets.PROXMOX_TOKEN_ID }}"
+          proxmox_token_secret       = "${{ secrets.PROXMOX_TOKEN_SECRET }}"
+          ssh_public_key             = "${{ secrets.SSH_PUBLIC_KEY }}"
+          forgejo_token              = "${{ secrets.GIT_TOKEN }}"
+          forgejo_repo_url           = "${{ secrets.GIT_REPO_URL }}"
+          k3s_version                = "v1.28.5+k3s1"
+          ubuntu_template            = "ubuntu-2404-cloudinit"
+          storage_pool               = "linstor_storage"
+          etcd_witness_storage_pool  = "local-lvm"
+          snippets_storage           = "local"
+          k3s_network_bridge         = "k3s"
+          k3s_gateway                = "10.100.20.1"
+          k3s_dns                    = ["10.100.20.1", "1.1.1.1"]
+          etcd_witness_config        = { ip = "10.100.20.30/24", cores = 2, memory = 2048, disk_size = "20G" }
           EOF
           tofu init
           tofu apply -auto-approve
diff --git a/terraform/pve1/main.tf b/terraform/pve1/main.tf
index 8db3b2a..a197292 100644
--- a/terraform/pve1/main.tf
+++ b/terraform/pve1/main.tf
@@ -25,6 +25,7 @@ resource "proxmox_vm_qemu" "k3s_server_1" {
   name        = "k3s-server-1"
   target_node = "acemagician"
   clone       = var.ubuntu_template
+  full_clone  = true
 
   cpu {
     cores   = var.k3s_server_1_config.cores
@@ -50,6 +51,7 @@ resource "proxmox_vm_qemu" "k3s_server_1" {
     type     = "disk"
     storage  = var.storage_pool
     iothread = true
+    replicate = 1
   }
 
   ipconfig0  = "ip=${var.k3s_server_1_config.ip},gw=${var.k3s_gateway}"
diff --git a/terraform/pve2/main.tf b/terraform/pve2/main.tf
index 047af38..3cbb0fc 100644
--- a/terraform/pve2/main.tf
+++ b/terraform/pve2/main.tf
@@ -25,6 +25,7 @@ resource "proxmox_vm_qemu" "k3s_server_2" {
   name        = "k3s-server-2"
   target_node = "elitedesk"
   clone       = var.ubuntu_template
+  full_clone  = true
 
   cpu {
     cores   = var.k3s_server_2_config.cores
@@ -50,6 +51,7 @@ resource "proxmox_vm_qemu" "k3s_server_2" {
     type     = "disk"
     storage  = var.storage_pool
     iothread = true
+    replicate = 1
   }
 
   ipconfig0  = "ip=${var.k3s_server_2_config.ip},gw=${var.k3s_gateway}"
diff --git a/terraform/pve3/main.tf b/terraform/pve3/main.tf
index 04cab29..9fcdde7 100644
--- a/terraform/pve3/main.tf
+++ b/terraform/pve3/main.tf
@@ -25,6 +25,7 @@ resource "proxmox_vm_qemu" "etcd_witness" {
   name        = "etcd-witness"
   target_node = "thinkpad"
   clone       = var.ubuntu_template
+  full_clone  = true
 
   cpu {
     cores   = var.etcd_witness_config.cores
@@ -48,7 +49,7 @@ resource "proxmox_vm_qemu" "etcd_witness" {
     slot     = "scsi0"
     size     = var.etcd_witness_config.disk_size
     type     = "disk"
-    storage  = var.storage_pool
+    storage  = var.etcd_witness_storage_pool
     iothread = true
   }
 
diff --git a/terraform/pve3/variables.tf b/terraform/pve3/variables.tf
index afd1599..4d3d7a6 100644
--- a/terraform/pve3/variables.tf
+++ b/terraform/pve3/variables.tf
@@ -53,6 +53,12 @@ variable "storage_pool" {
   type        = string
 }
 
+variable "etcd_witness_storage_pool" {
+  description = "Proxmox storage pool for etcd witness VM disk (thinkpad uses local storage)"
+  type        = string
+  default     = "local-lvm"
+}
+
 variable "snippets_storage" {
   description = "Proxmox storage for cloud-init snippets"
   type        = string